[webkit-reviews] review canceled: [Bug 89239] IndexedDB: Don't do full commit for read-only transactions : [Attachment 153369] Patch

[bugzilla-daemon at webkit.org]

Joshua Bell <jsbell at chromium.org> has canceled Joshua Bell
<jsbell at chromium.org>'s request for review:
Bug 89239: IndexedDB: Don't do full commit for read-only transactions
https://bugs.webkit.org/show_bug.cgi?id=89239

Attachment 153369: Patch
https://bugs.webkit.org/attachment.cgi?id=153369&action=review

------- Additional Comments from Joshua Bell <jsbell at chromium.org>
What happens when we iterate a cursor during a read-only transaction - do we
clean up stale entries? Should those be committed or should that wait for a
follow-up read/write transaction?

If we commit, then this doesn't address the scenario where this is defensive
against I/O errors.

If we don't commit, all subsequent transactions pay that penalty.

Also note that the patch as written checks at a lower level - if index cleanup
was done, it would still commit, so it's actually moot for this patch. I'm
tempted to land it as-is, but perhaps make the bug title less grandiose.