[webkit-reviews] review granted: [Bug 94417] [GTK] [WebKit2] Use XComposite window for accelerated compositing : [Attachment 164582] Fix embedded inspector and build errors for non TM builds

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 94417: [GTK] [WebKit2] Use XComposite window for accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=94417

Attachment 164582: Fix embedded inspector and build errors for non TM builds
https://bugs.webkit.org/attachment.cgi?id=164582&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=164582&action=review


Looks good to me, thanks!

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:367
> +    if (DrawingAreaProxyImpl* drawingArea =
static_cast<DrawingAreaProxyImpl*>(priv->pageProxy->drawingArea()))
> +	   drawingArea->setSize(viewRect.size(), IntSize());

setSize is in the parent class, so you don't need the cast, you can simply use
the code that we are currently using:

if (priv->pageProxy->drawingArea())
    priv->pageProxy->drawingArea()->setSize(viewRect.size(), IntSize());

> Source/WebKit2/UIProcess/WebPageProxy.messages.in:179
> +#

Extra # here