[webkit-reviews] review granted: [Bug 96497] [GTK] Add API to get/set the security policy of a given URI scheme to WebKit2 GTK+ : [Attachment 164548] New patch using a different API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 18 10:39:49 PDT 2012


Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 96497: [GTK] Add API to get/set the security policy of a given URI scheme
to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=96497

Attachment 164548: New patch using a different API
https://bugs.webkit.org/attachment.cgi?id=164548&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164548&action=review


Looks good. Couple small suggestions before landing...

> Source/WebKit2/UIProcess/API/gtk/WebKitSecurityManager.cpp:59
> +static void webkit_security_manager_class_init(WebKitSecurityManagerClass*
findClass)

Small nit here: findClass could just be klass or securityManagerClass. I guess
this is just a copy-paste thing?

> Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:318
> +    void check(const char* scheme, unsigned policy)

Maybe a name like verifyThatSchemeMatchesPolicy?


More information about the webkit-reviews mailing list