[webkit-reviews] review requested: [Bug 65766] [GTK] OSAllocator::reserveUncommitted should not commit physical memory : [Attachment 164570] New patch for using mmap(PROT_NONE) and mprotect() for reserving virtual memory.

[bugzilla-daemon at webkit.org]

Uli Schlachter <psychon at znc.in> has asked  for review:
Bug 65766: [GTK] OSAllocator::reserveUncommitted should not commit physical
memory
https://bugs.webkit.org/show_bug.cgi?id=65766

Attachment 164570: New patch for using mmap(PROT_NONE) and mprotect() for
reserving virtual memory.
https://bugs.webkit.org/attachment.cgi?id=164570&action=review

------- Additional Comments from Uli Schlachter <psychon at znc.in>
(In reply to comment #20)
> (In reply to comment #19)
> > Re-opened since this is blocked by 96966
> 
> The patch is reverted by https://trac.webkit.org/changeset/128818 
> because it broke everything. (At least Qt, GTK, EFL) No, I won't 
> upload backtraces, links, etc. build.webkit.org is your friend,
> you guys should have watch it after landing this patch ...

Urgh. I'm sorry. I did two big mistakes. The bigger one was not to test the
changes I did in response to the style warnings. The second mistake was
changing "if (mprotect() != 0)" into "if (!mprotect())".

So here is a new patch which removes those evil "!". I even tested this one.

Again: Sorry, entirely my fault.