[webkit-reviews] review granted: [Bug 96793] Title string should be changed when document.title is set to ''. : [Attachment 164551] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 18 07:53:21 PDT 2012
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Byungwoo Lee
<bw80.lee at samsung.com>'s request for review:
Bug 96793: Title string should be changed when document.title is set to ''.
https://bugs.webkit.org/show_bug.cgi?id=96793
Attachment 164551: Patch
https://bugs.webkit.org/attachment.cgi?id=164551&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164551&action=review
> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:516
> + printf("TITLE CHANGED: '%s'\n", (titleText && titleText->string) ?
titleText->string : "");
I wonder if "titleText->string : "None" makes most sense?
More information about the webkit-reviews
mailing list