[webkit-reviews] review denied: [Bug 17427] Line breaking opportunities at the end of a text node are missed : [Attachment 164327] Proposed patch

[bugzilla-daemon at webkit.org]

Alex Henrie <alexhenrie24 at gmail.com> has denied Alex Henrie
<alexhenrie24 at gmail.com>'s request for review:
Bug 17427: Line breaking opportunities at the end of a text node are missed
https://bugs.webkit.org/show_bug.cgi?id=17427

Attachment 164327: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=164327&action=review

------- Additional Comments from Alex Henrie <alexhenrie24 at gmail.com>
Okay, a few notes. text-combine-image-test.html is the test with the string
"20日". I looked at this test again and without any markup there is no line
break, so the line break my patch causes must be incorrect. However, I wasn't
able to investigate it further because I spent all my free time today trying to
recompile WebKit and when I run the GTK launcher all I get is a segmentation
fault. GDB reports:

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff4645a91 in JSC::ArrayConstructor::finishCreation(JSC::ExecState*,
JSC::ArrayPrototype*) ()
   from
/home/alex/webkit/WebKitBuild/Release/.libs/libjavascriptcoregtk-3.0.so.0

I used four characters because I thought that that was always going to be
enough context to determine line breaking, and in everything I've tested, it
is. However, reading UAX14 more closely it looks like Southeast Asian languages
(such as Thai) require dictionary-based line-breaking algorithms, which would
require more context. Do you know of a way to provide this context to the
line-breaking algorithm without allocating a new string and copying the
contents of the previous and current text nodes into it? Will Thai require more
context than just the first previous text node? Any tips on how to fix the
segfault?