[webkit-reviews] review granted: [Bug 95672] [EFL][WK2] Add javascript popup api. : [Attachment 164400] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Byungwoo Lee
<bw80.lee at samsung.com>'s request for review:
Bug 95672: [EFL][WK2] Add javascript popup api.
https://bugs.webkit.org/show_bug.cgi?id=95672

Attachment 164400: Patch
https://bugs.webkit.org/attachment.cgi?id=164400&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=164400&action=review


> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1627
> +

Add internal description like this,

/**
 * @internal
 * bla bla.
 */

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1638
> +

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1649
> +

ditto.