[webkit-reviews] review granted: [Bug 96959] Safari 6 notifications' onclick handlers can't call window.open() : [Attachment 164460] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jon Lee <jonlee at apple.com>'s request
for review:
Bug 96959: Safari 6 notifications' onclick handlers can't call window.open()
https://bugs.webkit.org/show_bug.cgi?id=96959

Attachment 164460: Patch
https://bugs.webkit.org/attachment.cgi?id=164460&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=164460&action=review


> Source/WebKit2/WebProcess/Notifications/WebNotificationManager.cpp:224
> +    UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);

A “why” comment would be welcome here. Also, I think the local variable can be
named "indicator".

Not caused by this patch: I also think that RAII objects with side effects need
clearer names. It’s not at all clear that an indicator is an object that
affects global state.