[webkit-reviews] review requested: [Bug 94743] Automatically use composited scrolling : [Attachment 164450] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 17 13:46:05 PDT 2012
vollick at chromium.org has asked for review:
Bug 94743: Automatically use composited scrolling
https://bugs.webkit.org/show_bug.cgi?id=94743
Attachment 164450: Patch
https://bugs.webkit.org/attachment.cgi?id=164450&action=review
------- Additional Comments from vollick at chromium.org
(In reply to comment #25)
> (From update of attachment 163954 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=163954&action=review
>
> > Source/WebCore/ChangeLog:9
> > + wkb.ug/91117 if the overflow scroll div is styled with
>
> nit: mention 'div' seems too specific. It can get applied to any block
element.
Fixed.
>
> > Source/WebCore/ChangeLog:14
> > +
>
> I think the most important thing to describe in the changelog here is the
heuristic you used.
Done.
>
> > Source/WebCore/rendering/RenderLayer.h:881
> > + // Returns true iff z ordering would not change if this layer were to
establish a stacking context.
>
> iff*
Fixed.
More information about the webkit-reviews
mailing list