[webkit-reviews] review granted: [Bug 96851] [chromium] WebCompositorOutputSurface software API : [Attachment 164434] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 17 13:39:58 PDT 2012


James Robinson <jamesr at chromium.org> has granted Alexandre Elias
<aelias at chromium.org>'s request for review:
Bug 96851: [chromium] WebCompositorOutputSurface software API
https://bugs.webkit.org/show_bug.cgi?id=96851

Attachment 164434: Patch
https://bugs.webkit.org/attachment.cgi?id=164434&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164434&action=review


> Source/Platform/chromium/public/WebCompositorSoftwareOutputDevice.h:44
> +    virtual WebImage* lock(bool forWrite) = 0;

It might be worth making this a 2-state enum - think about what the callsites
will look like. It's up to you.


More information about the webkit-reviews mailing list