[webkit-reviews] review granted: [Bug 96546] Delayed structure sweep can leak structures without bound : [Attachment 164420] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 96546: Delayed structure sweep can leak structures without bound
https://bugs.webkit.org/show_bug.cgi?id=96546

Attachment 164420: Patch
https://bugs.webkit.org/attachment.cgi?id=164420&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
"dtorType" - please rename to "destructorType" – WebKit style doesn't allow
abbreviation.

Is the idea that pretty much all classes that subclass JSNonFinalObject have
been changed to subclass JSDestructibleObject? – if so, I'd suggest it could be
a good idea to rename JSNonFinalObject, to enforce this & ensure no classes
have been missed.  Even if you don't want to land this, might be worth doing a
quick rename & floating a patch for the EWS system to test.