[webkit-reviews] review denied: [Bug 96112] [chromium] Allow WebViewClients to handle tap and longpress gesture events. : [Attachment 164415] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Oli Lan <olilan at chromium.org>'s
request for review:
Bug 96112: [chromium] Allow WebViewClients to handle tap and longpress gesture
events.
https://bugs.webkit.org/show_bug.cgi?id=96112

Attachment 164415: Patch
https://bugs.webkit.org/attachment.cgi?id=164415&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164415&action=review


Thanks.  This is much better.  A couple small points below.

> Source/WebKit/chromium/public/WebViewClient.h:147
> +    // Called when GestureTap or GestureLongPress are handled.
> +    virtual void didHandleTapEvent(int x, int y) { }
> +    virtual void didHandleLongPressEvent(int x, int y) { }

Should we just pass the whole WebGestureEvent?	The client might be interested
in more fields in the future and then we won't need to rev the API

> Source/WebKit/chromium/src/WebViewImpl.cpp:736
> +	   m_client->didHandleTapEvent(event.x, event.y);
> +
>	   return gestureHandled;

Do we want to call this API when gestureHandled is both true and when it is
false?	It seems a bit odd to tell the client that we handled this event when
gestureHandled is false...  Maybe we should pass this bool to the client?