[webkit-reviews] review granted: [Bug 93547] [CSS Exclusions] Enable shape-inside for percentage lengths based on logical height : [Attachment 164013] Use old-style updateLogicalHeight

[bugzilla-daemon at webkit.org]

Levi Weintraub <leviw at chromium.org> has granted Bear Travis
<betravis at adobe.com>'s request for review:
Bug 93547: [CSS Exclusions] Enable shape-inside for percentage lengths based on
logical height
https://bugs.webkit.org/show_bug.cgi?id=93547

Attachment 164013: Use old-style updateLogicalHeight
https://bugs.webkit.org/attachment.cgi?id=164013&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164013&action=review


LGTM.

>> Source/WebCore/rendering/RenderBlock.cpp:1397
>> +void RenderBlock::updateRegionsAndExclusionsLogicalSize()
> 
> Rehashing Hyatt's comment, this only deals with top and height, so the name
seems wrong.

computeExlucsionShapeSize does indeed need and use width, so I take this back.