[webkit-reviews] review granted: [Bug 96750] [BlackBerry] Prevent scroll adjustment of input fields when region of interest mechanism active : [Attachment 164252] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 17 07:04:25 PDT 2012
Antonio Gomes <tonikitoo at webkit.org> has granted Arvid Nilsson
<anilsson at rim.com>'s request for review:
Bug 96750: [BlackBerry] Prevent scroll adjustment of input fields when region
of interest mechanism active
https://bugs.webkit.org/show_bug.cgi?id=96750
Attachment 164252: Patch
https://bugs.webkit.org/attachment.cgi?id=164252&action=review
------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164252&action=review
> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1055
> - if
(!Platform::Settings::instance()->allowCenterScrollAdjustmentForInputFields()
&& scrollType != EdgeIfNeeded)
> + if
(!(Platform::Settings::instance()->allowedScrollAdjustmentForInputFields() &
scrollType))
I would name it scrollAdjustmentForInputFieldsPolicy, but this this also ok.
> Source/WebKit/blackberry/WebKitSupport/InputHandler.h:71
> + enum CaretScrollType { CenterAlways =
BlackBerry::Platform::Settings::ScrollAdjustmentCenterAlways,
> + CenterIfNeeded =
BlackBerry::Platform::Settings::ScrollAdjustmentCenterIfNeeded,
> + EdgeIfNeeded =
BlackBerry::Platform::Settings::ScrollAdjustmentEdgeIfNeeded };
there are compile asserts we can add to ensure these values match.
More information about the webkit-reviews
mailing list