[webkit-reviews] review granted: [Bug 96756] Web Inspector: automatically detect if class has reportMemoryUsage method : [Attachment 164350] comment addressed

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 96756: Web Inspector: automatically detect if class has reportMemoryUsage
method
https://bugs.webkit.org/show_bug.cgi?id=96756

Attachment 164350: comment addressed
https://bugs.webkit.org/attachment.cgi?id=164350&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164350&action=review


> Source/WTF/ChangeLog:8
> +	   Implemeted automatic selector of the memory reporting method. If

typo: Implemented

> Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp:294
> +TEST(MemoryInstrumentationTest, detectReportMemoryUsageMethod)

This test should either test both memory usage reporting methods or have a
different name that implies only the capability of addMember() to
reportMemoryUsage() (but not reportObjectInfo()) is tested.