[webkit-reviews] review granted: [Bug 96596] If a prototype has indexed setters and its instances have indexed storage, then all put_by_val's should have a bad time : [Attachment 164331] the patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 96596: If a prototype has indexed setters and its instances have indexed
storage, then all put_by_val's should have a bad time
https://bugs.webkit.org/show_bug.cgi?id=96596

Attachment 164331: the patch
https://bugs.webkit.org/attachment.cgi?id=164331&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
I'd like to see a test case that cover a couple of cross-frame scenarios.  E.g.
I have two frames, one adds a numeric setter to its array prototype, the second
frame behaves correctly wrt to array objects from the first frame.  (The patch
looks like it will handle any cases I can think of correctly, since having a
bad time is related to array creation, just would like to see test coverage for
this).

Still, this is awesome enough as is & there is plenty of test coverage already
in this patch, so r+.