[webkit-reviews] review requested: [Bug 96890] REGRESSION (r126763): css1/pseudo/firstline.html fails when using the complex text code path : [Attachment 164325] Invalidate the TextLayout on font change

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 96890: REGRESSION (r126763): css1/pseudo/firstline.html fails when using
the complex text code path
https://bugs.webkit.org/show_bug.cgi?id=96890

Attachment 164325: Invalidate the TextLayout on font change
https://bugs.webkit.org/attachment.cgi?id=164325&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164325&action=review


> Source/WebCore/ChangeLog:10
> +	   When a first-line style specifies a font, different pieces of the
same RednerText can be

RenderText

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2440
> +		   renderTextInfo.m_font = &f;

Do we ever need to clear this pointer?