[webkit-reviews] review requested: [Bug 96596] If a prototype has indexed setters and its instances have indexed storage, then all put_by_val's should have a bad time : [Attachment 164311] the patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has asked  for review:
Bug 96596: If a prototype has indexed setters and its instances have indexed
storage, then all put_by_val's should have a bad time
https://bugs.webkit.org/show_bug.cgi?id=96596

Attachment 164311: the patch
https://bugs.webkit.org/attachment.cgi?id=164311&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
The differences from the previously reviewed patch:

- Added JSObject::unwrappedGlobalObject(), since globalObject() doesn't work
for global-this.  That was causing assertion failures.

- Added JSValue::putToPrimitiveByIndex() and refactored
JSObject::attemptToInterceptPutByIndexOnHole() so that the logic can be shared.