[webkit-reviews] review granted: [Bug 95409] IndexedDB: Use ScriptValue instead of SerializedScriptValue for get/openCursor : [Attachment 164206] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Alec Flett
<alecflett at chromium.org>'s request for review:
Bug 95409: IndexedDB: Use ScriptValue instead of SerializedScriptValue for
get/openCursor
https://bugs.webkit.org/show_bug.cgi?id=95409

Attachment 164206: Patch
https://bugs.webkit.org/attachment.cgi?id=164206&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164206&action=review


LGTM with some nits.

> Source/WebCore/Modules/indexeddb/IDBAny.h:63
> +    static PassRefPtr<IDBAny> create(const T& idbObject)

Are both create(const T& idbObject) and create(PassRefPtr<T> idbObject) needed?
You might want to remove create(PassRefPtr<T> idbObject) in favor of
create(const T& idbObject).

> Source/WebCore/Modules/indexeddb/IDBCursor.cpp:276
> +	       ASSERT_UNUSED(injected, injected);

Given that the current code has ASSERT(valueAfterInjection), shouldn't this be
ASSERT(injected)?

> Source/WebCore/Modules/indexeddb/IDBCursor.cpp:277
>	       // FIXME: There is no way to report errors here. Move this into
onSuccessWithContinuation so that we can abort the transaction there. See:
https://bugs.webkit.org/show_bug.cgi?id=92278

You can move this comment to just before the ASSERT().

> Source/WebCore/Modules/indexeddb/IDBRequest.cpp:376
> +    ASSERT(injected);
> +    if (!injected) {

This code looks a bit strange:

- If 'injected' can be 0, 'ASSERT(injected)' should be removed.
- If 'injected' shouldn't be 0, 'if (!injected)' should be removed.