[webkit-reviews] review granted: [Bug 96837] We should make collecting metrics easier by adding an IDL attribute : [Attachment 164249] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 96837: We should make collecting metrics easier by adding an IDL attribute
https://bugs.webkit.org/show_bug.cgi?id=96837

Attachment 164249: Patch
https://bugs.webkit.org/attachment.cgi?id=164249&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164249&action=review


The V8 binding LGTM. Do you have any plan to support [MeasureAs] in JSC?

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1828
> +END
> +    push(@implContent,
GenerateFeatureObservation($function->signature->extendedAttributes->{"MeasureA
s"}));
> +
> +    push(@implContent, <<END);

Nit: For readability, shall we avoid the END? You can store the result of
GenerateFeatureObservation() to some variable before line 1822 and use the
variable here.

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2023
> +END
> +    push(@implContent,
GenerateFeatureObservation($function->signature->extendedAttributes->{"MeasureA
s"}));
> +
> +    push(@implContent, <<END);

Ditto.