[webkit-reviews] review granted: [Bug 96790] Prevent workers from calling back into other worlds : [Attachment 164161] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dan Carney <dcarney at google.com>'s
request for review:
Bug 96790: Prevent workers from calling back into other worlds
https://bugs.webkit.org/show_bug.cgi?id=96790

Attachment 164161: Patch
https://bugs.webkit.org/attachment.cgi?id=164161&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164161&action=review


> Source/WebCore/bindings/v8/WorldContextHandle.cpp:51
> +    if (v8::Context::InContext()) {
> +	   v8::Handle<v8::Context> context = v8::Context::GetCurrent();
> +	   if (!context.IsEmpty()) {

This is somewhat redundant.  You can skip the v8::Context::InContext() call and
just test whether v8::Context::GetCurrent() returns an empty handle.