[webkit-reviews] review denied: [Bug 95134] [chromium] Support high DPI scroll bar on top level web frame. : [Attachment 163918] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 14 13:00:42 PDT 2012


Adrienne Walker <enne at google.com> has denied Robert Flack
<flackr at chromium.org>'s request for review:
Bug 95134: [chromium] Support high DPI scroll bar on top level web frame.
https://bugs.webkit.org/show_bug.cgi?id=95134

Attachment 163918: Patch
https://bugs.webkit.org/attachment.cgi?id=163918&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=163918&action=review


I like the changes.  This code has all moved.  Can you create a Chromium bug
and rebase your Source/WebCore/platform/graphics/chromium/cc on top of /cc
instead? I'll lgtm that.

> Source/WebKit/chromium/src/NonCompositedContentHost.cpp:34
> +#include "LayerChromium.h"

You can't include or use LayerChromium in NonCompositedContentHost.  You have
to go through WebContentLayer.


More information about the webkit-reviews mailing list