[webkit-reviews] review granted: [Bug 96801] [CSS Shaders] Refactor FECustomFilter to make it usable from platform dependent implementations : [Attachment 164184] Patch V3

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 96801: [CSS Shaders] Refactor FECustomFilter to make it usable from
platform dependent implementations
https://bugs.webkit.org/show_bug.cgi?id=96801

Attachment 164184: Patch V3
https://bugs.webkit.org/attachment.cgi?id=164184&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=164184&action=review


I didn't look through this so carefully since I'd already done it in the
original bug :)

> Source/WebCore/platform/graphics/filters/FECustomFilter.cpp:185
> +    // Only allocate a texture if the program needs one and the caller
doesn't allocate one by itself.
> +    if (programNeedsInputTexture() && (filterDrawType ==
NEEDS_INPUT_TEXTURE) && !ensureInputTexture())
> +	   return false;
> +    if (!ensureFrameBuffer())
> +	   return false;

Any reason why we don't merge that into one test?