[webkit-reviews] review granted: [Bug 95098] [Chromium] DRT does not support --dump-all-pixels flag : [Attachment 160744] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Stephen Chenney
<schenney at chromium.org>'s request for review:
Bug 95098: [Chromium] DRT does not support --dump-all-pixels flag
https://bugs.webkit.org/show_bug.cgi?id=95098

Attachment 160744: Patch
https://bugs.webkit.org/attachment.cgi?id=160744&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
I think the patch looks fine (ish).  However, I think it'd be better if we just
went back to supporting -p/--pixel-tests for this, rather than using
--dump-all-pixels (at least that would be consistent with the per-test flag).

While I think we should implement this on all the ports, we don't need to do it
in this patch (and while it would be nice of you to implement it everywhere, I
don't think we need to require that). r+ w/ these changes; if you disagree, let
me know.