[webkit-reviews] review requested: [Bug 49072] Loader cleanup : Simplify FrameLoader/DocumentLoader setupForReplace() : [Attachment 164191] patch + test

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 49072: Loader cleanup : Simplify FrameLoader/DocumentLoader
setupForReplace()
https://bugs.webkit.org/show_bug.cgi?id=49072

Attachment 164191: patch + test
https://bugs.webkit.org/attachment.cgi?id=164191&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
This patch is in the same theme of the one I wrote 2 years ago, but the low
hanging fruit in the referenced functions has changed almost completely since
then.

See WebCore/ChangeLog for a full list of the changes, but note that this does
modify behavior in the case of text/html multipart pieces.  Our behavior in
that case appears to date back to WebKit's initial multipart/x-mixed-replace
support in trac.webkit.org/changeset/10489, but I can't find a rationale for
it.  The behavior of this patch seems better to me (i.e., the document isn't
blank).