[webkit-reviews] review granted: [Bug 96687] [Chromium] Support the --{in, out, err}-fifo arguments on TestWebKitAPI and webkit_unit_tests : [Attachment 164158] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 14 10:24:15 PDT 2012


Tony Chang <tony at chromium.org> has granted Peter Beverloo
<peter at chromium.org>'s request for review:
Bug 96687: [Chromium] Support the --{in,out,err}-fifo arguments on
TestWebKitAPI and webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=96687

Attachment 164158: Patch
https://bugs.webkit.org/attachment.cgi?id=164158&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
Putting the target in WebKitUnitTests.gyp is fine. I'm not sure if it's weirder
to has test libraries in WebKit.gyp or to have DumpRenderTree.gyp depend on
WebKitUnitTests.gyp.  *shrug*


More information about the webkit-reviews mailing list