[webkit-reviews] review granted: [Bug 57570] WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks : [Attachment 164123] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 14 09:32:27 PDT 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 57570: WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
https://bugs.webkit.org/show_bug.cgi?id=57570

Attachment 164123: Patch
https://bugs.webkit.org/attachment.cgi?id=164123&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164123&action=review


> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:546
> +    if (!newQuota) {
> +	   WebProcess::shared().connection()->sendSync(
> +	      
Messages::WebPageProxy::ExceededDatabaseQuota(webFrame->frameID(),
origin->databaseIdentifier(), databaseName, details.displayName(),
currentQuota, currentOriginUsage, details.currentUsage(),
details.expectedUsage()),
> +	       Messages::WebPageProxy::ExceededDatabaseQuota::Reply(newQuota),
m_page->pageID());
> +    }

So zero can not exceed, makes sense


More information about the webkit-reviews mailing list