[webkit-reviews] review granted: [Bug 96668] [CSS Shaders] Enable anti-aliasing on the FECustomFilter : [Attachment 164007] Patch V1

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 96668: [CSS Shaders] Enable anti-aliasing on the FECustomFilter
https://bugs.webkit.org/show_bug.cgi?id=96668

Attachment 164007: Patch V1
https://bugs.webkit.org/attachment.cgi?id=164007&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=164007&action=review


> Source/WebCore/platform/graphics/filters/FECustomFilter.cpp:351
> +    int sampleCount = std::min(4, maxSampleCount);

While it's only used here, I think we should define a MAX_CUSTOM_SAMPLES or
something at the top of the file.

> Source/WebCore/platform/graphics/filters/FECustomFilter.cpp:362
> +    m_context->bindFramebuffer(GraphicsContext3D::FRAMEBUFFER,
m_multisampleFrameBuffer);
> +
> +    m_context->bindRenderbuffer(GraphicsContext3D::RENDERBUFFER,
m_multisampleRenderBuffer);

nit: remove blank line