[webkit-reviews] review granted: [Bug 96755] Web Inspector: reuse WebInspector.ProgressIndicator in Audits panel : [Attachment 164119] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 14 05:54:00 PDT 2012


Alexander Pavlov (apavlov) <apavlov at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 96755: Web Inspector: reuse WebInspector.ProgressIndicator in Audits panel
https://bugs.webkit.org/show_bug.cgi?id=96755

Attachment 164119: Patch
https://bugs.webkit.org/attachment.cgi?id=164119&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164119&action=review


> Source/WebCore/inspector/front-end/AuditsPanel.js:180
> +	       function onReload()

You could move it a bit above and call from the "if (runImmediately)" branch
(changing the name appropriately) to reduce code duplication.


More information about the webkit-reviews mailing list