[webkit-reviews] review canceled: [Bug 96755] Web Inspector: reuse WebInspector.ProgressIndicator in Audits panel : [Attachment 164108] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has canceled Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 96755: Web Inspector: reuse WebInspector.ProgressIndicator in Audits panel
https://bugs.webkit.org/show_bug.cgi?id=96755

Attachment 164108: Patch
https://bugs.webkit.org/attachment.cgi?id=164108&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164108&action=review


> Source/WebCore/ChangeLog:8
> +	   Additional information of the change such as approach, rationale.
Please add per-function descriptions below (OOPS!).

I don't believe this line should be here.

> Source/WebCore/ChangeLog:10
> +	   - remove AuditProgressMonitor, use WebInspector.ProgressIndicator
instead

Please use item delimiters consistently (semicolons, commas, periods,
whatever).

> Source/WebCore/ChangeLog:12
> +	   - simplify control flow -- remove callbacks where possible;

and this one should end in a period, it seems

>	       this._setAuditRunning(true);

tip: you could try extracting this along with its counterpart as
this._setAuditRunning(!this._auditRunning);

> Source/WebCore/inspector/front-end/AuditRules.js:77
> +	* @param {WebInspector.NetworkRequest} requests

Can you explain this change? The new annotations should not compile. Same thing
for the other rules' doRun().