[webkit-reviews] review denied: [Bug 96626] Web Inspector: Group selectors to highlight matched selector in the Styles pane of Elements Panel : [Attachment 164080] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 14 04:03:48 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 96626: Web Inspector: Group selectors to highlight matched selector in the
Styles pane of Elements Panel
https://bugs.webkit.org/show_bug.cgi?id=96626

Attachment 164080: Patch
https://bugs.webkit.org/attachment.cgi?id=164080&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164080&action=review


>> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1180
>> +		    self._selectorElement.innerHTML = selectors.join(", ");
> 
> We should use appendChild

+1. Let's agree that any assignment of innerHTML to non-empy string is an
automatic r- in the inspector codebase.


More information about the webkit-reviews mailing list