[webkit-reviews] review requested: [Bug 96714] [Forms] multiple fields time input UI should save/restore its value even if it has an empty field. : [Attachment 164082] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 14 03:02:41 PDT 2012


yosin at chromium.org has asked  for review:
Bug 96714: [Forms] multiple fields time input UI should save/restore its value
even if it has an empty field.
https://bugs.webkit.org/show_bug.cgi?id=96714

Attachment 164082: Patch 2
https://bugs.webkit.org/attachment.cgi?id=164082&action=review

------- Additional Comments from yosin at chromium.org
Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Increment version number in formControlSignatre() in FormController.cpp
* Changes variable name to dateTimeFieldsState for DateTimeFieldsState
* DateTimeFieldElements.cpp: Checks incoming value from DateTimeFieldsState in
setValueAsDateTimeFieldsState


More information about the webkit-reviews mailing list