[webkit-reviews] review granted: [Bug 95187] Web Inspector: Add ability to replay XHR in network panel. : [Attachment 164070] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 95187: Web Inspector: Add ability to replay XHR in network panel.
https://bugs.webkit.org/show_bug.cgi?id=95187

Attachment 164070: Patch
https://bugs.webkit.org/attachment.cgi?id=164070&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164070&action=review


> Source/WebCore/inspector/InspectorResourceAgent.cpp:-364
> -void InspectorResourceAgent::willLoadXHRSynchronously()

Let's keep will/didLoadXHRSynchronously as before for clarity as discussed off
the bug.

> Source/WebCore/inspector/InspectorResourceAgent.cpp:618
> +    xhr->sendFromInspector(xhrReplayData->formData(), code);return;

Remove 'return;'

> Source/WebCore/loader/DocumentThreadableLoader.cpp:410
> +#if ENABLE(INSPECTOR)

No need in this guard as we already have one in the InspectorInstrumentation