[webkit-reviews] review denied: [Bug 96714] [Forms] multiple fields time input UI should save/restore its value even if it has an empty field. : [Attachment 164073] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 96714: [Forms] multiple fields time input UI should save/restore its value
even if it has an empty field.
https://bugs.webkit.org/show_bug.cgi?id=96714

Attachment 164073: Patch 1
https://bugs.webkit.org/attachment.cgi?id=164073&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164073&action=review


You need to increment the version number in FormCotroller.cpp
formStateSignature() because this is an incompatible change.

> Source/WebCore/html/shadow/DateTimeFieldElements.cpp:146
> +	   DateTimeNumericFieldElement::setValueAsInteger(hour12);

We need to do something for out-of-range values.
The hour12 value comes from a serialized state, and it might be corrupted.

> Source/WebCore/html/shadow/DateTimeFieldElements.cpp:156
> +	       DateTimeNumericFieldElement::setValueAsInteger(hour12 == 12 ? 12
: hour12 + 12);

ditto.

> Source/WebCore/html/shadow/DateTimeFieldElements.cpp:158
> +	       DateTimeNumericFieldElement::setValueAsInteger(hour12);

ditto.

> Source/WebCore/html/shadow/DateTimeFieldElements.cpp:209
> +	   setValueAsInteger(dateTimeFieldsState.millisecond());

ditto.

> Source/WebCore/html/shadow/DateTimeFieldElements.cpp:247
> +	   setValueAsInteger(dateTimeFieldsState.minute());

ditto.

> Source/WebCore/html/shadow/DateTimeFieldElements.cpp:285
> +	   setValueAsInteger(dateTimeFieldsState.second());

ditto.