[webkit-reviews] review denied: [Bug 90659] Web Inspector: Option to filter search based on source type in Advanced-Search : [Attachment 163532] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 14 02:08:22 PDT 2012
Vsevolod Vlasov <vsevik at chromium.org> has denied sam <dsam2912 at gmail.com>'s
request for review:
Bug 90659: Web Inspector: Option to filter search based on source type in
Advanced-Search
https://bugs.webkit.org/show_bug.cgi?id=90659
Attachment 163532: Patch
https://bugs.webkit.org/attachment.cgi?id=163532&action=review
------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163532&action=review
> Source/WebCore/inspector/front-end/AdvancedSearchController.js:428
> + var preTokens =
queryString.match(/([^\s]*\"([^\\"]|\\\\|\\")*\"[^\s]*)|([^\s]+)/gi);
I don't think this regular expression is correctly parsing the examples set I
suggested before.
More information about the webkit-reviews
mailing list