[webkit-reviews] review granted: [Bug 96662] Web Inspector: [Tests] Extract a common method for sending xhrs from tests. : [Attachment 163891] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 96662: Web Inspector: [Tests] Extract a common method for sending xhrs from
tests.
https://bugs.webkit.org/show_bug.cgi?id=96662

Attachment 163891: Patch
https://bugs.webkit.org/attachment.cgi?id=163891&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163891&action=review


> LayoutTests/ChangeLog:3
> +	   Web Inspector: [Tests] Extract a common method for sending xhrs from
tests.

WebKit convention is to capitalize full acronyms, even in identifiers (like
"runXHRTest")

> LayoutTests/http/tests/inspector/network-test.js:98
> +function makeXHR(jsonArgs)

Please come up with a consistent naming convention for these methods (doXHR vs.
makeXHR vs. InspectorTest.makeXHR*)