[webkit-reviews] review granted: [Bug 96614] Need to clear exception in JSDictionary for operations that might have. : [Attachment 164065] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 96614: Need to clear exception in JSDictionary for operations that might
have.
https://bugs.webkit.org/show_bug.cgi?id=96614

Attachment 164065: Patch
https://bugs.webkit.org/attachment.cgi?id=164065&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164065&action=review


OK.

> Source/WebCore/bindings/js/JSDictionary.h:150
> +	       m_exec->clearException();
>	       return ExceptionThrown;

At first I thought that this will make it impossible to retrieve the exception
later. But the fact that we return 'ExceptionThrown' means that we're no longer
interested in what exception was thrown. In that sense, clearing the exception
here would make sense.