[webkit-reviews] review granted: [Bug 96726] Refactor time format related methods on LocaleWin/Mac/ICU so that they override Localizer methods : [Attachment 164048] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 96726: Refactor time format related methods on LocaleWin/Mac/ICU so that
they override Localizer methods
https://bugs.webkit.org/show_bug.cgi?id=96726

Attachment 164048: Patch
https://bugs.webkit.org/attachment.cgi?id=164048&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164048&action=review


ok

> Source/WebCore/ChangeLog:34
> +	   * platform/text/LocaleICU.cpp:
> +	   (WebCore::LocaleICU::initializeDateTimeFormat):
> +	   (WebCore::LocaleICU::timeFormatText):
> +	   (WebCore::LocaleICU::shortTimeFormatText):
> +	   (WebCore::LocaleICU::timeAMPMLabels):
> +	   * platform/text/LocaleICU.h:
> +	   (LocaleICU):
> +	   * platform/text/LocaleWin.h:
> +	   (LocaleWin):
> +	   * platform/text/LocalizedDateICU.cpp:
> +	   (WebCore::localizedTimeFormatText):
> +	   (WebCore::localizedShortTimeFormatText):
> +	   * platform/text/Localizer.cpp:
> +	   (WebCore):
> +	   (WebCore::Localizer::timeFormatText):
> +	   (WebCore::Localizer::shortTimeFormatText):
> +	   (WebCore::Localizer::timeAMPMLabels):
> +	   * platform/text/Localizer.h:
> +	   (Localizer):
> +	   * platform/text/mac/LocaleMac.h:
> +	   (LocaleMac):

Please write what is changed for each files/functions as possible.