[webkit-reviews] review requested: [Bug 93547] [CSS Exclusions] Enable shape-inside for percentage lengths based on logical height : [Attachment 164013] Use old-style updateLogicalHeight

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 13 17:42:04 PDT 2012


Bear Travis <betravis at adobe.com> has asked  for review:
Bug 93547: [CSS Exclusions] Enable shape-inside for percentage lengths based on
logical height
https://bugs.webkit.org/show_bug.cgi?id=93547

Attachment 164013: Use old-style updateLogicalHeight
https://bugs.webkit.org/attachment.cgi?id=164013&action=review

------- Additional Comments from Bear Travis <betravis at adobe.com>
Simplify patch to use updateLogicalHeight, rather than the const
computeLogicalHeight. The code should eventually use computeLogicalHeight, but
several areas of the code need to be modified to not use the side effects of
updateLogicalHeight.


More information about the webkit-reviews mailing list