[webkit-reviews] review denied: [Bug 96687] [Chromium] Support the --{in, out, err}-fifo arguments on TestWebKitAPI and webkit_unit_tests : [Attachment 163946] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Peter Beverloo <peter at chromium.org>'s
request for review:
Bug 96687: [Chromium] Support the --{in,out,err}-fifo arguments on
TestWebKitAPI and webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=96687

Attachment 163946: Patch
https://bugs.webkit.org/attachment.cgi?id=163946&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163946&action=review


It sounds like you're saying it'll be a long time before running gtests in
Chromium will be stable enough for us to use, so we should use this in the
meantime.  I think that's fine, but please make sure to have a tracking bug
about switching over to a common framework.  For example, why can't Chromium
use an approach like this?

> Source/WebKit/chromium/WebKit.gypi:246
> +		   'webkit_unittest_files': [
> +		       'tests/ForwardIOStreamsAndroid.cpp',
> +		       'tests/ForwardIOStreamsAndroid.h',

Please put this into a separate static_library target and have the three
targets depend on it rather than compiling it three times.