[webkit-reviews] review denied: [Bug 96181] [WK2][WTR] CodeGeneratorTestRunner could keep original copyright. : [Attachment 163976] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 13 17:00:53 PDT 2012


Daniel Bates <dbates at webkit.org> has denied Kangil Han
<kangil.han at samsung.com>'s request for review:
Bug 96181: [WK2][WTR] CodeGeneratorTestRunner could keep original copyright.
https://bugs.webkit.org/show_bug.cgi?id=96181

Attachment 163976: patch
https://bugs.webkit.org/attachment.cgi?id=163976&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
It seems more appropriate to associate the path to the idl file with the
CodeGeneratorTestRunner instance instead of storing this information in a
file-level scope variable. We should also consider caching the license block
that we parse from the idl file so that we don't read and parse the file twice
for each call to GenerateInterface(). I need to run, but I'll comment further
on this patch later tonight.


More information about the webkit-reviews mailing list