[webkit-reviews] review denied: [Bug 96657] [chromium] Add test for ScrollingCoordinatorChromium : [Attachment 163887] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Sami Kyöstilä
<skyostil at chromium.org>'s request for review:
Bug 96657: [chromium] Add test for ScrollingCoordinatorChromium
https://bugs.webkit.org/show_bug.cgi?id=96657

Attachment 163887: Patch
https://bugs.webkit.org/attachment.cgi?id=163887&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163887&action=review


I really like the idea but this won't quite build as is - gonna need to do some
more plumbing or expose this at a different level.

> Source/WebKit/chromium/tests/ScrollingCoordinatorChromiumTest.cpp:32
> +#include "LayerChromium.h"

you can't make a test that depends on WebCore stuff and LayerChromium any more.
 You gotta plumb what you want through the public Web*Layer* headers if you
want to access it from a webkit_unit_test

> Source/WebKit/chromium/tests/ScrollingCoordinatorChromiumTest.cpp:38
> +#include "WebLayerImpl.h"

Can't see this either - now that WebLayerImpl is implemented in chromium the
WebLayer type is completely opaque even to this unit test.  You can either
write the whole test on the chromium side or plumb it through the WebKit API