[webkit-reviews] review granted: [Bug 96426] percentage heights in quirks mode with auto-sized body are computed incorrectly : [Attachment 163972] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 96426: percentage heights in quirks mode with auto-sized body are computed
incorrectly
https://bugs.webkit.org/show_bug.cgi?id=96426

Attachment 163972: Patch
https://bugs.webkit.org/attachment.cgi?id=163972&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
(In reply to comment #10)
> (From update of attachment 163912 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=163912&action=review
> 
> >>> Source/WebCore/rendering/RenderBox.cpp:2136
> >>>		   break;
> >> 
> >> In quirks mode, it looks like it's possible for cb to be NULL now. How do
we exit this loop?
> > 
> > I think we always hit the !cb->isRenderView() case. Do we ever have an root
renderbox (i.e. html element) that is not contained in a RenderView?
> 
> What happens in a DocumentFragment?

Ojan tells me that DocumentFragment's don't have a render tree, so they don't
go through this code path.