[webkit-reviews] review granted: [Bug 96226] REGRESSION (r128006): Three spatial navigation tests are failing : [Attachment 163744] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 13 15:29:02 PDT 2012
Ryosuke Niwa <rniwa at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 96226: REGRESSION (r128006): Three spatial navigation tests are failing
https://bugs.webkit.org/show_bug.cgi?id=96226
Attachment 163744: Patch
https://bugs.webkit.org/attachment.cgi?id=163744&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163744&action=review
rs=me. I've verified that this patch reverts
http://trac.webkit.org/changeset/128006/trunk/Source/WebCore/dom/ContainerNode.
cpp.
> Source/WebCore/dom/ContainerNode.cpp:762
> + // do nothing - skip unrendered whitespace that is a child
or next sibling of the anchor
Wont indentation.
> Source/WebCore/dom/ContainerNode.cpp:767
> +
toRenderText(o)->firstTextBox()->root()->lineTop());
Ditto.
More information about the webkit-reviews
mailing list