[webkit-reviews] review granted: [Bug 86363] Add the event handler content attributes that are defined in the spec to HTMLElement : [Attachment 157380] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 86363: Add the event handler content attributes that are defined in the
spec to HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=86363

Attachment 157380: Patch
https://bugs.webkit.org/attachment.cgi?id=157380&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157380&action=review


> Source/WebCore/html/HTMLElement.cpp:294
> +	   attributeNameToEventNameMap.set(onwaitingAttr.localName(),
eventNames().waitingEvent);
> +	   attributeNameToEventNameMap.set(onwaitingAttr.localName(),
eventNames().waitingEvent);

Waiting is repeated twice. Please fix it.

> LayoutTests/fast/events/event-attribute.html:16
> +var eventNames = ["onclick", "oncontextmenu", "ondblclick", "onmousedown",

Shouldn't we test all event handlers?