[webkit-reviews] review granted: [Bug 96453] run-perf-tests output cryptic error when the config file is missing. : [Attachment 163968] Fixed one typo

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 96453: run-perf-tests output cryptic error when the config file is missing.
https://bugs.webkit.org/show_bug.cgi?id=96453

Attachment 163968: Fixed one typo
https://bugs.webkit.org/attachment.cgi?id=163968&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163968&action=review


> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:224
> +	       slave_config_json =
self._host.filesystem.open_text_file_for_reading(slave_config_json_path)

Nit: Should we move this line out of the try block now?

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:226
> +	       return dict(slave_config.items() + output.items())

Nit: I would probably also move this line out of the try as well and make the
Exception clear that it's a JSON error.