[webkit-reviews] review granted: [Bug 93898] Add optional debug logging when we fall into/out of threaded scrolling : [Attachment 163738] don't rename all of the functions

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 93898: Add optional debug logging when we fall into/out of threaded
scrolling
https://bugs.webkit.org/show_bug.cgi?id=93898

Attachment 163738: don't rename all of the functions
https://bugs.webkit.org/attachment.cgi?id=163738&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=163738&action=review


r=me but please consider suggested renames.

> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:398
> +    if (m_page->mainFrame()->document()->isImageDocument())
> +	   reasonsForUpdatingScrollLayerPositionOnMainThread |=
IsImageDocument;

What about media documents, PDFs etc? Do we care?

> Source/WebCore/page/scrolling/ScrollingCoordinator.h:47
> +typedef unsigned ReasonForUpdatingScrollLayerPositionOnMainThreadFlags;

It's odd that this typedef is outside class scope, but the flags are inside.
Such a long name! How about MainThreadScrollingReasons?

> Source/WebCore/page/scrolling/ScrollingCoordinator.h:132
> +    enum ReasonForUpdatingScrollLayerPositionOnMainThread {

And MainThreadScrollingReasonFlags?

> Source/WebCore/page/scrolling/ScrollingTreeState.cpp:94
> +    if ((bool)m_shouldUpdateScrollLayerPositionOnMainThread ==
(bool)reasons)
>	   return;

I think C++ will do the type coercion for you.