[webkit-reviews] review denied: [Bug 96688] Put position:fixed elements in their own layers and allow them to create a stacking context : [Attachment 163951] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 96688: Put position:fixed elements in their own layers and allow them to
create a stacking context
https://bugs.webkit.org/show_bug.cgi?id=96688

Attachment 163951: Patch
https://bugs.webkit.org/attachment.cgi?id=163951&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=163951&action=review


> Source/WebKit/mac/WebView/WebView.mm:1553
> +    settings->setAcceleratedCompositingForFixedPositionEnabled(true);

I don' think we want to force compositing layers for position:fixed in WK1...

> Source/WebKit/mac/WebView/WebView.mm:1554
> +    settings->setFixedPositionCreatesStackingContext(true);

But we do want this one to avoid rendering differences.