[webkit-reviews] review granted: [Bug 95885] Add new accelerated compositing for overflow scroll setting. : [Attachment 163898] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Glenn Hartmann
<hartmanng at chromium.org>'s request for review:
Bug 95885: Add new accelerated compositing for overflow scroll setting.
https://bugs.webkit.org/show_bug.cgi?id=95885

Attachment 163898: Patch
https://bugs.webkit.org/attachment.cgi?id=163898&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163898&action=review


R=me but you have some more consistency issues to fix.

> Source/WebCore/page/Settings.cpp:465
> +    m_acceleratedCompositingForOverflowScrollEnabled = enable;

put this inline like the other setAcceleratedCompositing... functions in
Settings.h

> Source/WebCore/page/Settings.h:666
> +	   bool m_acceleratedCompositingForOverflowScrollEnabled : 1;

Move this down next to the other m_acceleratedCompositing.. bits

> Source/WebKit/chromium/public/WebSettings.h:140
> +    virtual void setAcceleratedCompositingForOverflowScrollEnabled(bool) =
0;

Put this next to the other setAccelerated... setters up around lines 6067. 
Notice how the rest of this file is alphabetical?

> Source/WebKit/chromium/src/WebSettingsImpl.cpp:390
> +void WebSettingsImpl::setAcceleratedCompositingForOverflowScrollEnabled(

Move the implementation of this to match the header order

> Source/WebKit/chromium/src/WebSettingsImpl.h:135
> +    virtual void setAcceleratedCompositingForOverflowScrollEnabled(bool);

Alphabetize