[webkit-reviews] review denied: [Bug 96659] Evas_Object* is a ref'ed structure, so tread it as such : [Attachment 163902] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 96659: Evas_Object* is a ref'ed structure, so tread it as such
https://bugs.webkit.org/show_bug.cgi?id=96659

Attachment 163902: Patch
https://bugs.webkit.org/attachment.cgi?id=163902&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163902&action=review


> Source/WTF/wtf/RefPtr.h:212
> +#if PLATFORM(EFL)
> +typedef struct _Evas_Object Evas_Object;
> +
> +namespace WTF {
> +
> +template<> void refIfNotNull(Evas_Object* ptr);
> +template<> void derefIfNotNull(Evas_Object* ptr);
> +
> +}
> +#endif

I don't think we should be adding EFL-specific code to RefPtr.h.  Notice that
we don't do the same thing for integration with CF ref counting.